Thread (6 messages) 6 messages, 2 authors, 2021-07-05

Re: [PATCH v8 3/8] security/brute: Detect a brute force attack

From: Alexander Lobakin <hidden>
Date: 2021-07-05 12:52:37
Also in: linux-doc, linux-hardening, linux-kselftest, linux-security-module, lkml

From: John Wood <redacted>
Date: Sun, 4 Jul 2021 16:01:08 +0200
On Sat, Jul 03, 2021 at 12:59:28PM +0200, John Wood wrote:
quoted
Hi,

On Fri, Jul 02, 2021 at 05:08:09PM +0000, Alexander Lobakin wrote:
quoted
On the other hand, it leaves a potentional window for attackers to
perform brute force from xattr-incapable filesystems. So at the end
of the day I think that the current implementation (a strong
rejection of such filesystems) is way more secure than having
a fallback I proposed.
I've been thinking more about this: that the Brute LSM depends on xattr
support and I don't like this part. I want that brute force attacks can
be detected and mitigated on every system (with minimal dependencies).
So, now I am working in a solution without this drawback. I have some
ideas but I need to work on it.
I have been coding and testing a bit my ideas but:

Trying to track the applications faults info using kernel memory ends up
in an easy to abuse system (denied of service due to large amount of memor=
y
in use) :(

So, I continue with the v8 idea: xattr to track application crashes info.
quoted
quoted
I'm planning to make a patch which will eliminate such weird rootfs
type selection and just always use more feature-rich tmpfs if it's
compiled in. So, as an alternative, you could add it to your series
as a preparatory change and just add a Kconfig dependency on
CONFIG_TMPFS && CONFIG_TMPFS_XATTR to CONFIG_SECURITY_FORK_BRUTE
without messing with any fallbacks at all.
What do you think?
Great. But I hope this patch will not be necessary for Brute LSM :)
My words are no longer valid ;)
Ok, so here's the patch that prefers tmpfs for rootfs over ramfs
if it's built-in (which is true for 99% of systems): [0]

For now it hasn't been reviewed by anyone yet, will see. I'm running
my system with this patch for several days already and there were no
issues with rootfs or Brute so far.

[0] https://lore.kernel.org/lkml/20210702233727.21301-1-alobakin@pm.me/ (local)
Thanks,
John Wood
Thanks,
Al
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help