Re: [PATCH v3 6/9] microblaze: use generic strncpy/strnlen from_user

On Thu, Jul 22, 2021 at 10:48 PM kernel test robot [off-list ref] wrote:

All errors (new ones prefixed by >>):

   lib/strncpy_from_user.c: In function 'strncpy_from_user':

quoted

quoted

lib/strncpy_from_user.c:123:13: error: implicit declaration of function 'user_addr_max' [-Werror=implicit-function-declaration]

     123 |  max_addr = user_addr_max();
         |             ^~~~~~~~~~~~~
   cc1: some warnings being treated as errors

--

quoted

quoted

lib/strnlen_user.c:92:6: error: conflicting types for 'strnlen_user'

      92 | long strnlen_user(const char __user *str, long count)
         |      ^~~~~~~~~~~~
   In file included from include/linux/uaccess.h:11,
                    from lib/strnlen_user.c:4:
   arch/microblaze/include/asm/uaccess.h:306:13: note: previous declaration of 'strnlen_user' was here
     306 | extern long strnlen_user(const char __user *sstr, int len);

Fixed both now, thanks for the report.

I had to add a user_addr_max() definition here, which unfortunately
will also conflict
with the get_fs() removal if Christoph plans to have that merged
through the microblaze
tree.

If this becomes a problem, I could merge both series through the
asm-generic tree.

     Arnd