Re: [PATCH v2 2/7] sched: Introduce task_is_running()

From
Peter Zijlstra <peterz@infradead.org>
Date
2021-06-11 09:17:24
Also in
lkml
Reply to
Geert Uytterhoeven, 2021-06-11
On Fri, Jun 11, 2021 at 10:49:56AM +0200, Geert Uytterhoeven wrote:
Hoi Peter,

Thanks for your patch!

On Fri, Jun 11, 2021 at 10:36 AM Peter Zijlstra [off-list ref] wrote:
quoted
Replace a bunch of 'p->state == TASK_RUNNING' with a new helper:
task_is_running(p).
You're also sticking a READ_ONCE() in the helper, which wasn't done
by any of the old implementations? Care to mention why?
Patch 7/7 should clarify. Arguably I should leave the READ_ONCE() off
here and only add it there.

Thread (12 messages) 12 messages, 4 authors, last reply 2021-06-16
Keyboard shortcuts
hback out one level
jnext message in thread / next series-diff position
kprevious message in thread / previous series-diff position
ldrill in
Escclose help / fold thread tree
?toggle this help