Re: [PATCH v2 2/7] sched: Introduce task_is_running()

[PATCH v2 0/7] Cleanup task_struct::state · Peter Zijlstra <peterz@infradead.org> · 2021-06-11
[PATCH v2 4/7] sched: Add get_current_state() · Peter Zijlstra <peterz@infradead.org> · 2021-06-11
[PATCH v2 1/7] sched: Unbreak wakeups · Peter Zijlstra <peterz@infradead.org> · 2021-06-11
[PATCH v2 5/7] sched,timer: Use __set_current_state() · Peter Zijlstra <peterz@infradead.org> · 2021-06-11
[PATCH v2 3/7] sched,perf,kvm: Fix preemption condition · Peter Zijlstra <peterz@infradead.org> · 2021-06-11
[PATCH v2 7/7] sched: Change task_struct::state · Peter Zijlstra <peterz@infradead.org> · 2021-06-11
Re: [PATCH v2 7/7] sched: Change task_struct::state · Daniel Bristot de Oliveira <hidden> · 2021-06-16
[PATCH v2 2/7] sched: Introduce task_is_running() · Peter Zijlstra <peterz@infradead.org> · 2021-06-11
Re: [PATCH v2 2/7] sched: Introduce task_is_running() · Geert Uytterhoeven <geert@linux-m68k.org> · 2021-06-11
Re: [PATCH v2 2/7] sched: Introduce task_is_running() · Peter Zijlstra <peterz@infradead.org> · 2021-06-11
Re: [PATCH v2 2/7] sched: Introduce task_is_running() · Will Deacon <will@kernel.org> · 2021-06-11
[PATCH v2 6/7] sched,arch: Remove unused TASK_STATE offsets · Peter Zijlstra <peterz@infradead.org> · 2021-06-11

From: Peter Zijlstra <peterz@infradead.org>
Date: 2021-06-11 09:17:24
Also in: lkml

On Fri, Jun 11, 2021 at 10:49:56AM +0200, Geert Uytterhoeven wrote:

Hoi Peter,

Thanks for your patch!

On Fri, Jun 11, 2021 at 10:36 AM Peter Zijlstra [off-list ref] wrote:

quoted

Replace a bunch of 'p->state == TASK_RUNNING' with a new helper:
task_is_running(p).

You're also sticking a READ_ONCE() in the helper, which wasn't done
by any of the old implementations? Care to mention why?

Patch 7/7 should clarify. Arguably I should leave the READ_ONCE() off
here and only add it there.