Thread (2 messages) 2 messages, 2 authors, 2021-05-19

Re: [PATCH v3 1/4] kexec: simplify compat_sys_kexec_load

From: Arnd Bergmann <arnd@kernel.org>
Date: 2021-05-19 09:56:25
Also in: kexec, linux-arm-kernel, linux-mm, lkml

Possibly related (same subject, not in this thread)

On Wed, May 19, 2021 at 12:45 AM Eric W. Biederman
[off-list ref] wrote:
Arnd Bergmann [off-list ref] writes:
quoted
On Tue, May 18, 2021 at 4:05 PM Arnd Bergmann [off-list ref] wrote:
quoted
On Tue, May 18, 2021 at 3:41 PM Eric W. Biederman [off-list ref] wrote:
I think something like the untested diff below is enough to get rid of
compat_alloc_user cleanly.

Certainly it should be enough to give any idea what I am thinking.
Yes, that looks sufficient to me. I had started a slightly different
approach by trying
to move the kimage_alloc_init() into the top-level entry points to
avoid the extra
kmalloc, but that got rather complicated, and your patch is simpler overall.

The allocation could still be combined with kexec_load_check() into a new
function to reduce the number of duplicate lines, but if you think the current
version is ok, then I'll leave this part as it is.

I've fixed a duplicate kfree() and some whitespace damage, and rebased the
rest of my series on top of this to give it a spin on the build test boxes.
I'll send a v4 series once I have made sure there are no build-time regressions.

Can I add your Signed-off-by for the patch?
Is there a set of tests I should run on it?

      Arnd
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help