Thread (35 messages) 35 messages, 8 authors, 2021-03-29

Re: [PATCH v3 05/17] workqueue: use WARN_ON_FUNCTION_MISMATCH

From: Kees Cook <hidden>
Date: 2021-03-26 04:35:43
Also in: bpf, linux-arm-kernel, linux-hardening, linux-kbuild, linux-pci, lkml

On Tue, Mar 23, 2021 at 01:39:34PM -0700, Sami Tolvanen wrote:
With CONFIG_CFI_CLANG, a callback function passed to
__queue_delayed_work from a module points to a jump table entry
defined in the module instead of the one used in the core kernel,
which breaks function address equality in this check:

  WARN_ON_ONCE(timer->function != delayed_work_timer_fn);

Use WARN_ON_FUNCTION_MISMATCH() instead to disable the warning
when CFI and modules are both enabled.

Signed-off-by: Sami Tolvanen <samitolvanen@google.com>
Reviewed-by: Kees Cook <redacted>

-- 
Kees Cook
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help