Read the whole thread, 66 messages PreviousNext Re: [PATCH v23 12/28] x86/mm: Update ptep_set_wrprotect() and pmdp_set_wrprotect() for transition from _PAGE_DIRTY to _PAGE_COW FromPeter Zijlstra <peterz@infradead.org> Date2021-03-22 10:49:27 Also inlinux-api, linux-doc, linux-mm, lkmlReply toKirill A. Shutemov, 2021-03-22 On Mon, Mar 22, 2021 at 01:15:02PM +0300, Kirill A. Shutemov wrote:On Tue, Mar 16, 2021 at 08:10:38AM -0700, Yu-cheng Yu wrote:quoted+ pte_t old_pte, new_pte; + + old_pte = READ_ONCE(*ptep); + do { + new_pte = pte_wrprotect(old_pte); + } while (!try_cmpxchg(&ptep->pte, &old_pte.pte, new_pte.pte)); I think this is wrong. You need to update old_pte on every loop iteration, otherwise you can get in to endless loop. It is correct, please consider why the old argument is a pointer.
Keyboard shortcuts hback out one level jnext message in thread / next series-diff position kprevious message in thread / previous series-diff position ldrill in Escclose help / fold thread tree ?toggle this help