Thread (42 messages) 42 messages, 4 authors, 2021-03-17

Re: [PATCH 05/17] workqueue: cfi: disable callback pointer check with modules

From: Kees Cook <hidden>
Date: 2021-03-12 02:43:55
Also in: bpf, linux-arm-kernel, linux-hardening, linux-kbuild, linux-pci, lkml

On Thu, Mar 11, 2021 at 04:49:07PM -0800, Sami Tolvanen wrote:
With CONFIG_CFI_CLANG, a callback function passed to
__queue_delayed_work from a module points to a jump table entry
defined in the module instead of the one used in the core kernel,
which breaks function address equality in this check:

  WARN_ON_ONCE(timer->function != delayed_work_timer_fn);

Disable the warning when CFI and modules are enabled.
Reviewed-by: Kees Cook <redacted>

-- 
Kees Cook
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help