Thread (134 messages) 134 messages, 10 authors, 2021-04-01

Re: [RFT PATCH v3 18/27] tty: serial: samsung_tty: Separate S3C64XX ops structure

From: Krzysztof Kozlowski <hidden>
Date: 2021-03-05 10:31:29
Also in: linux-arm-kernel, linux-devicetree, linux-doc, linux-samsung-soc, linux-serial, lkml

On 04/03/2021 22:38, Hector Martin wrote:
Instead of patching a single global ops structure depending on the port
type, use a separate s3c64xx_serial_ops for the S3C64XX type. This
allows us to mark the structures as const.

Also split out s3c64xx_serial_shutdown into a separate function now that
we have a separate ops structure; this avoids excessive branching
control flow and mirrors s3c64xx_serial_startup. tx_claimed and
rx_claimed are only used in the S3C24XX functions.

Signed-off-by: Hector Martin <redacted>
---
 drivers/tty/serial/samsung_tty.c | 71 ++++++++++++++++++++++++--------
 1 file changed, 54 insertions(+), 17 deletions(-)

Reviewed-by: Krzysztof Kozlowski <redacted>
Tested-by: Krzysztof Kozlowski <redacted>

Best regards,
Krzysztof
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help