Re: [PATCH v7 1/2] Kbuild: make DWARF version a choice
From: Nick Desaulniers <hidden>
Date: 2021-02-04 06:17:10
Also in:
linux-kbuild, lkml
On Wed, Feb 3, 2021 at 4:30 PM Masahiro Yamada [off-list ref] wrote:
On Thu, Feb 4, 2021 at 8:16 AM Nick Desaulniers [off-list ref] wrote:quoted
On Wed, Feb 3, 2021 at 2:24 PM Masahiro Yamada [off-list ref] wrote:quoted
On Sat, Jan 30, 2021 at 10:52 AM Nathan Chancellor [off-list ref] wrote:quoted
On Fri, Jan 29, 2021 at 04:44:00PM -0800, Nick Desaulniers wrote:quoted
Modifies CONFIG_DEBUG_INFO_DWARF4 to be a member of a choice which is the default. Does so in a way that's forward compatible with existing configs, and makes adding future versions more straightforward. GCC since ~4.8 has defaulted to this DWARF version implicitly. Suggested-by: Arvind Sankar <redacted> Suggested-by: Fangrui Song <redacted> Suggested-by: Nathan Chancellor <nathan@kernel.org> Suggested-by: Masahiro Yamada <masahiroy@kernel.org> Signed-off-by: Nick Desaulniers <redacted>One comment below: Reviewed-by: Nathan Chancellor <nathan@kernel.org>quoted
--- Makefile | 5 ++--- lib/Kconfig.debug | 16 +++++++++++----- 2 files changed, 13 insertions(+), 8 deletions(-)diff --git a/Makefile b/Makefile index 95ab9856f357..d2b4980807e0 100644 --- a/Makefile +++ b/Makefile@@ -830,9 +830,8 @@ ifneq ($(LLVM_IAS),1) KBUILD_AFLAGS += -Wa,-gdwarf-2It is probably worth a comment somewhere that assembly files will still have DWARF v2.I agree. Please noting the reason will be helpful.Via a comment in the source, or in the commit message?quoted
Could you summarize Jakub's comment in short? https://patchwork.kernel.org/project/linux-kbuild/patch/20201022012106.1875129-1-ndesaulniers@google.com/#23727667Via a comment in the source, or in the commit message?Both in the source if you can summarize it in three lines or so. If you need to add more detailed explanation, please provide it in the commit log.
This information is mostly in the commit log of patch 2. I will reword it with additional info from the link you sent, but I find that such minutiae is resulting in diminishing returns on subsequent respins of the patch series. I implore you to reword v8 (which I will send) as you see fit when applying the series. -- Thanks, ~Nick Desaulniers