Re: [PATCH 6/8] lib: inline _find_next_bit() wrappers
From: Yury Norov <yury.norov@gmail.com>
Date: 2021-02-02 07:14:53
Also in:
linux-m68k, linux-sh, lkml
From: Yury Norov <yury.norov@gmail.com>
Date: 2021-02-02 07:14:53
Also in:
linux-m68k, linux-sh, lkml
On Mon, Feb 1, 2021 at 5:47 AM Andy Shevchenko [off-list ref] wrote:
On Sat, Jan 30, 2021 at 11:17:17AM -0800, Yury Norov wrote:quoted
lib/find_bit.c declares five single-line wrappers for _find_next_bit(). We may turn those wrappers to inline functions. It eliminates unneeded function calls and opens room for compile-time optimizations.quoted
tools/include/asm-generic/bitops/find.h | 27 +++++++++--- tools/lib/find_bit.c | 52 ++++++++++-------------In a separated patch, please. I don't think we need to defer this series in case if tools lagged (which is usual case in my practice).
Splitting it to kernel and tools parts means either a patch bomb for tools or doubling the size of the series. Both options look worse than what we have now. Can you explain more on the lagged tools argument?
-- With Best Regards, Andy Shevchenko