Thread (34 messages) 34 messages, 6 authors, 2020-08-05

Re: [PATCH v2 13/17] x86/setup: simplify initrd relocation and reservation

From: Ingo Molnar <mingo@kernel.org>
Date: 2020-08-02 18:01:20
Also in: linux-arm-kernel, linux-iommu, linux-mips, linux-mm, linux-riscv, linux-s390, linux-sh, linuxppc-dev, lkml, sparclinux

* Mike Rapoport [off-list ref] wrote:
From: Mike Rapoport <redacted>

Currently, initrd image is reserved very early during setup and then it
might be relocated and re-reserved after the initial physical memory
mapping is created. The "late" reservation of memblock verifies that mapped
memory size exceeds the size of initrd, the checks whether the relocation
required and, if yes, relocates inirtd to a new memory allocated from
memblock and frees the old location.

The check for memory size is excessive as memblock allocation will anyway
fail if there is not enough memory. Besides, there is no point to allocate
memory from memblock using memblock_find_in_range() + memblock_reserve()
when there exists memblock_phys_alloc_range() with required functionality.

Remove the redundant check and simplify memblock allocation.

Signed-off-by: Mike Rapoport <redacted>
Assuming there's no hidden dependency here breaking something:

  Acked-by: Ingo Molnar [off-list ref]

Thanks,

	Ingo
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help