On Mon, Aug 13, 2018 at 12:17 PM, Pu Wen [off-list ref] wrote:

On 2018/8/12 3:56, Michael Jin wrote:

quoted

On Sat, Aug 11, 2018 at 9:30 AM, Pu Wen [off-list ref] wrote:

quoted

diff --git a/drivers/edac/amd64_edac.c b/drivers/edac/amd64_edac.c
-       if (pvt->fam == 0x17) {
+       if (pvt->fam == 0x17 || pvt->vendor == X86_VENDOR_HYGON) {
                 __f17h_set_scrubval(pvt, scrubval);

Separating the vendor check as an "else if (pvt->vendor ==
X86_VENDOR_HYGON)" block would make architectural changes (future
hygon models, i.e. 19h, 20h, etc) less confusing.

Your suggestion is reasonable, but that might make the branch a little
complicated.If we explicitly testing Hygon family in condition case,
will that be ok?
+    if (pvt->fam == 0x17 ||
+       (pvt->vendor == X86_VENDOR_HYGON && pvt->fam == 0x18))

The condition case for family 18h and vendor Hygon looks better
because it is more clear.

Michael