Re: [PATCH v6 17/28] x86/asm: use SYM_INNER_LABEL instead of GLOBAL
From: Ingo Molnar <mingo@kernel.org>
Date: 2018-05-19 07:44:22
Also in:
lkml
From: Ingo Molnar <mingo@kernel.org>
Date: 2018-05-19 07:44:22
Also in:
lkml
* Andy Lutomirski [off-list ref] wrote:
On Fri, May 18, 2018 at 2:17 AM Jiri Slaby [off-list ref] wrote:quoted
GLOBAL had several meanings and is going away. In this patch, convert all the inner function labels marked with GLOBAL to use SYM_INNER_LABEL instead.quoted
Note that retint_user needs not be global, perhaps since commit 2ec67971facc ("x86/entry/64/compat: Remove most of the fast system call machinery"), where entry_64_compat's caller was removed. So mark the label as LOCAL.quoted
-GLOBAL(entry_SYSCALL_64_after_hwframe) +SYM_INNER_LABEL(entry_SYSCALL_64_after_hwframe, SYM_L_GLOBAL)I've missed all the context here. I agree that GLOBAL is misleading, and "inner label" is nice. But this is a rather wordy macro. Would: INNER_LABEL_GLOBAL(name) be better? (With just INNER_LABEL(name) for the local version?)
Please keep the SYM_ global namespace for all these symbol macros - but the rest of the name can be shortened. Thanks, Ingo