Re: [PATCH 6/8] kprobes/arm64: Fix %p uses in error messages
From: Masami Hiramatsu <mhiramat@kernel.org>
Date: 2018-01-26 05:41:01
Also in:
lkml
On Thu, 25 Jan 2018 16:42:31 +0000 Will Deacon [off-list ref] wrote:
On Thu, Jan 25, 2018 at 02:29:32PM +0900, Masami Hiramatsu wrote:quoted
Fix %p uses in error messages by removing it because those are redundant or meaningless. Signed-off-by: Masami Hiramatsu <mhiramat@kernel.org> --- arch/arm64/kernel/probes/kprobes.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)Acked-by: Will Deacon <redacted> I guess Catalin can just pick this one up via arm64.
OK, thanks!
Willquoted
diff --git a/arch/arm64/kernel/probes/kprobes.c b/arch/arm64/kernel/probes/kprobes.c index d849d9804011..34f78d07a068 100644 --- a/arch/arm64/kernel/probes/kprobes.c +++ b/arch/arm64/kernel/probes/kprobes.c@@ -275,7 +275,7 @@ static int __kprobes reenter_kprobe(struct kprobe *p, break; case KPROBE_HIT_SS: case KPROBE_REENTER: - pr_warn("Unrecoverable kprobe detected at %p.\n", p->addr); + pr_warn("Unrecoverable kprobe detected.\n"); dump_kprobe(p); BUG(); break;@@ -521,7 +521,7 @@ int __kprobes longjmp_break_handler(struct kprobe *p, struct pt_regs *regs) (struct pt_regs *)kcb->jprobe_saved_regs.sp; pr_err("current sp %lx does not match saved sp %lx\n", orig_sp, stack_addr); - pr_err("Saved registers for jprobe %p\n", jp); + pr_err("Saved registers for jprobe\n"); __show_regs(saved_regs); pr_err("Current registers\n"); __show_regs(regs);
-- Masami Hiramatsu [off-list ref]