Thread (92 messages) 92 messages, 13 authors, 2017-12-08

Re: [PATCH v2 06/35] nds32: MMU fault handling and page table management

From: Greentime Hu <hidden>
Date: 2017-12-08 05:27:27
Also in: linux-devicetree, linux-serial, lkml, netdev

2017-12-08 0:40 GMT+08:00 Al Viro [off-list ref]:
On Mon, Nov 27, 2017 at 08:27:53PM +0800, Greentime Hu wrote:
quoted
+void do_page_fault(unsigned long entry, unsigned long addr,
+                unsigned int error_code, struct pt_regs *regs)
[snip]
quoted
+     /*
+      * If we're in an interrupt or have no user
+      * context, we must not take the fault..
+      */
+     if (unlikely(in_atomic() || !mm))
Broken.  in_atomic() is wrong here - it should be faulthandler_disabled().
Thanks.
I will include <linux/uaccess.h> and replace in_atomic() with
faulthandler_disabled()
I will fix it in the next version patch.
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help