Thread (12 messages) 12 messages, 2 authors, 2017-08-18

Re: [PATCH v2 6/6] kernel: tracepoints: add support for relative references

From: Steven Rostedt <rostedt@goodmis.org>
Date: 2017-08-18 13:52:14
Also in: lkml

On Fri, 18 Aug 2017 14:44:15 +0100
Ard Biesheuvel [off-list ref] wrote:
quoted
quoted
It appears the stuff above needs to be move inside the double-include
guard (which oddly enough does not cover the entire file)  
Why was this moved to the header file? To fulfill some checkpatch
warning?
 
Yes.
My preference is to ignore that checkpatch warning. The section
variables are created by linker magic, and not normal "extern"
variables. They are only used in one location, and I like to keep them
where they are used, and not be something other places might think they
can be used. In other words, keep them by the C code, and out of
headers.

Tracepoints and linker/asm work always triggers a lot of bogus
checkpatch warnings. Which is unfortunate. :-/

Thanks!

-- Steve
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help