On Fri, Jan 27, 2017 at 02:24:58PM +0100, Vlastimil Babka wrote:

On 12/27/2016 02:53 AM, Kirill A. Shutemov wrote:

quoted

We are going to introduce <asm-generic/pgtable-nop4d.h> to provide
abstraction for properly (in opposite to 5level-fixup.h hack) folded
p4d level. The new header will be included from pgtable-nopud.h.

If an architecture uses <asm-generic/nop*d.h>, we cannot use
5level-fixup.h directly to quickly convert the architecture to 5-level
paging as it would conflict with pgtable-nop4d.h.

With this patch an architecture can define __ARCH_USE_5LEVEL_HACK before
inclusion <asm-genenric/nop*d.h> to 5level-fixup.h.

Signed-off-by: Kirill A. Shutemov <redacted>
---
include/asm-generic/pgtable-nop4d-hack.h | 62 ++++++++++++++++++++++++++++++++

At risk of bikeshedding and coming from somebody not familiar with this
code... IMHO it would be somewhat more intuitive and consistent to name the
file "pgtable-nopud-hack.h" as it's about the pud stuff, not p4d stuff, and
acts as an alternative implementation to pgtable-nopud.h, not
pgtable-nop4d.h

Well, on other hand we hack-in p4d level here...

I don't really care. Either way works for me.

-- 
 Kirill A. Shutemov

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>