Re: [PATCH v4 01/16] bluetooth: Switch SMP to crypto_cipher_encrypt_one()
From: Johan Hedberg <hidden>
Date: 2016-06-24 07:19:22
Also in:
linux-bluetooth, lkml, netdev
From: Johan Hedberg <hidden>
Date: 2016-06-24 07:19:22
Also in:
linux-bluetooth, lkml, netdev
On Thu, Jun 23, 2016, Andy Lutomirski wrote:
SMP does ECB crypto on stack buffers. This is complicated and fragile, and it will not work if the stack is virtually allocated. Switch to the crypto_cipher interface, which is simpler and safer. Cc: Marcel Holtmann <marcel@holtmann.org> Cc: Gustavo Padovan <redacted> Cc: Johan Hedberg <redacted> Cc: "David S. Miller" <davem@davemloft.net> Cc: linux-bluetooth@vger.kernel.org Cc: Herbert Xu <herbert@gondor.apana.org.au> Cc: netdev@vger.kernel.org Signed-off-by: Andy Lutomirski <luto@kernel.org> --- net/bluetooth/smp.c | 67 ++++++++++++++++++++++------------------------------- 1 file changed, 28 insertions(+), 39 deletions(-)
Acked-and-tested-by: Johan Hedberg [off-list ref] Johan