Re: [PATCH -v2 19/33] locking,powerpc: Implement... | linux-arch

[PATCH -v2 00/33] implement atomic_fetch_$op · Peter Zijlstra <peterz@infradead.org> · 2016-05-31
[PATCH -v2 29/33] locking: Remove the deprecated atomic_{set,clear}_mask() functions · Peter Zijlstra <peterz@infradead.org> · 2016-05-31
[PATCH -v2 18/33] locking,parisc: Implement atomic{,64}_fetch_{add,sub,and,or,xor}() · Peter Zijlstra <peterz@infradead.org> · 2016-05-31
[PATCH -v2 12/33] locking,ia64: Implement atomic{,64}_fetch_{add,sub,and,or,xor}() · Peter Zijlstra <peterz@infradead.org> · 2016-05-31
[PATCH -v2 06/33] locking,arm64: Implement atomic{,64}_fetch_{add,sub,and,andnot,or,xor}{,_relaxed,_acquire,_release}() for LSE instructions · Peter Zijlstra <peterz@infradead.org> · 2016-05-31
[PATCH -v2 10/33] locking,h8300: Implement atomic_fetch_{add,sub,and,or,xor}() · Peter Zijlstra <peterz@infradead.org> · 2016-05-31
[PATCH -v2 13/33] locking,m32r: Implement atomic_fetch_{add,sub,and,or,xor}() · Peter Zijlstra <peterz@infradead.org> · 2016-05-31
[PATCH -v2 02/33] locking,arc: Implement atomic_fetch_{add,sub,and,andnot,or,xor}() · Peter Zijlstra <peterz@infradead.org> · 2016-05-31
[PATCH -v2 27/33] locking: Implement atomic{,64,_long}_fetch_{add,sub,and,andnot,or,xor}{,_relaxed,_acquire,_release}() · Peter Zijlstra <peterz@infradead.org> · 2016-05-31
[PATCH -v2 32/33] locking,qrwlock: Employ atomic_fetch_add_acquire() · Peter Zijlstra <peterz@infradead.org> · 2016-05-31
[PATCH -v2 24/33] locking,x86: Implement atomic{,64}_fetch_{add,sub,and,or,xor}() · Peter Zijlstra <peterz@infradead.org> · 2016-05-31
[PATCH -v2 33/33] locking,rwsem: Employ atomic_long_fetch_add() · Peter Zijlstra <peterz@infradead.org> · 2016-05-31
[PATCH -v2 31/33] locking,mips: Convert to _relaxed atomics · Peter Zijlstra <peterz@infradead.org> · 2016-05-31
[PATCH -v2 15/33] locking,metag: Implement atomic_fetch_{add,sub,and,or,xor}() · Peter Zijlstra <peterz@infradead.org> · 2016-05-31
[PATCH -v2 21/33] locking,sh: Implement atomic_fetch_{add,sub,and,or,xor}() · Peter Zijlstra <peterz@infradead.org> · 2016-05-31
[PATCH -v2 01/33] locking,alpha: Implement atomic{,64}_fetch_{add,sub,and,andnot,or,xor}() · Peter Zijlstra <peterz@infradead.org> · 2016-05-31
[PATCH -v2 05/33] arm64: atomic: generate LSE non-return cases using common macros · Peter Zijlstra <peterz@infradead.org> · 2016-05-31
[PATCH -v2 07/33] locking,avr32: Implement atomic_fetch_{add,sub,and,or,xor}() · Peter Zijlstra <peterz@infradead.org> · 2016-05-31
[PATCH -v2 28/33] locking: Remove linux/atomic.h:atomic_fetch_or · Peter Zijlstra <peterz@infradead.org> · 2016-05-31
[PATCH -v2 25/33] locking,xtensa: Implement atomic_fetch_{add,sub,and,or,xor}() · Peter Zijlstra <peterz@infradead.org> · 2016-05-31
[PATCH -v2 22/33] locking,sparc: Implement atomic{,64}_fetch_{add,sub,and,or,xor}() · Peter Zijlstra <peterz@infradead.org> · 2016-05-31
Re: [PATCH -v2 22/33] locking,sparc: Implement atomic{,64}_fetch_{add,sub,and,or,xor}() · David Miller <davem@davemloft.net> · 2016-05-31
[PATCH -v2 09/33] locking,frv: Implement atomic{,64}_fetch_{add,sub,and,or,xor}() · Peter Zijlstra <peterz@infradead.org> · 2016-05-31
[PATCH -v2 26/33] locking: Fix atomic64_relaxed bits · Peter Zijlstra <peterz@infradead.org> · 2016-05-31
[PATCH -v2 23/33] locking,tile: Implement atomic{,64}_fetch_{add,sub,and,or,xor}() · Peter Zijlstra <peterz@infradead.org> · 2016-05-31
[PATCH -v2 16/33] locking,mips: Implement atomic{,64}_fetch_{add,sub,and,or,xor}() · Peter Zijlstra <peterz@infradead.org> · 2016-05-31
[PATCH -v2 14/33] locking,m68k: Implement atomic_fetch_{add,sub,and,or,xor}() · Peter Zijlstra <peterz@infradead.org> · 2016-05-31
Re: [PATCH -v2 14/33] locking,m68k: Implement atomic_fetch_{add,sub,and,or,xor}() · Geert Uytterhoeven <geert@linux-m68k.org> · 2016-06-16
Re: [PATCH -v2 14/33] locking,m68k: Implement atomic_fetch_{add,sub,and,or,xor}() · Peter Zijlstra <peterz@infradead.org> · 2016-06-16
[PATCH -v2 11/33] locking,hexagon: Implement atomic_fetch_{add,sub,and,or,xor}() · Peter Zijlstra <peterz@infradead.org> · 2016-05-31
[PATCH -v2 17/33] locking,mn10300: Implement atomic_fetch_{add,sub,and,or,xor}() · Peter Zijlstra <peterz@infradead.org> · 2016-05-31
[PATCH -v2 20/33] locking,s390: Implement atomic{,64}_fetch_{add,sub,and,or,xor}() · Peter Zijlstra <peterz@infradead.org> · 2016-05-31
[PATCH -v2 03/33] locking,arm: Implement atomic{,64}_fetch_{add,sub,and,andnot,or,xor}{,_relaxed,_acquire,_release}() · Peter Zijlstra <peterz@infradead.org> · 2016-05-31
[PATCH -v2 04/33] locking,arm64: Implement atomic{,64}_fetch_{add,sub,and,andnot,or,xor}{,_relaxed,_acquire,_release}() · Peter Zijlstra <peterz@infradead.org> · 2016-05-31
[PATCH -v2 19/33] locking,powerpc: Implement atomic{,64}_fetch_{add,sub,and,or,xor}{,_relaxed,_acquire,_release}() · Peter Zijlstra <peterz@infradead.org> · 2016-05-31
Re: [PATCH -v2 19/33] locking,powerpc: Implement atomic{,64}_fetch_{add,sub,and,or,xor}{,_relaxed,_acquire,_release}() · Boqun Feng <hidden> · 2016-06-01
Re: [PATCH -v2 19/33] locking,powerpc: Implement atomic{,64}_fetch_{add,sub,and,or,xor}{,_relaxed,_acquire,_release}() · Boqun Feng <hidden> · 2016-06-01
Re: [PATCH -v2 19/33] locking,powerpc: Implement atomic{,64}_fetch_{add,sub,and,or,xor}{,_relaxed,_acquire,_release}() · Peter Zijlstra <peterz@infradead.org> · 2016-06-01
[PATCH -v2 08/33] locking,blackfin: Implement atomic_fetch_{add,sub,and,or,xor}() · Peter Zijlstra <peterz@infradead.org> · 2016-05-31
[PATCH -v2 30/33] locking,alpha: Convert to _relaxed atomics · Peter Zijlstra <peterz@infradead.org> · 2016-05-31
Re: [PATCH -v2 00/33] implement atomic_fetch_$op · Will Deacon <hidden> · 2016-06-01
Re: [PATCH -v2 00/33] implement atomic_fetch_$op · Vineet Gupta <hidden> · 2016-06-02
Re: [PATCH -v2 00/33] implement atomic_fetch_$op · Peter Zijlstra <peterz@infradead.org> · 2016-06-02
Re: [PATCH -v2 00/33] implement atomic_fetch_$op · Peter Zijlstra <peterz@infradead.org> · 2016-06-08
Re: [PATCH -v2 00/33] implement atomic_fetch_$op · Ingo Molnar <mingo@kernel.org> · 2016-06-08
Re: [PATCH -v2 00/33] implement atomic_fetch_$op · Peter Zijlstra <peterz@infradead.org> · 2016-06-08
Re: [PATCH -v2 00/33] implement atomic_fetch_$op · Vineet Gupta <hidden> · 2016-06-08
Re: [PATCH -v2 00/33] implement atomic_fetch_$op · Peter Zijlstra <peterz@infradead.org> · 2016-06-08

Re: [PATCH -v2 19/33] locking,powerpc: Implement atomic{,64}_fetch_{add,sub,and,or,xor}{,_relaxed,_acquire,_release}()

From: Boqun Feng <hidden>
Date: 2016-06-01 03:08:11
Also in: lkml

Hi Peter,

On Tue, May 31, 2016 at 12:19:44PM +0200, Peter Zijlstra wrote:
[snip]

quoted hunk ↗ jump to hunk

@@ -329,20 +361,53 @@ atomic64_##op##_return_relaxed(long a, a
 	return t;							\
 }
 
+#define ATOMIC64_FETCH_OP_RELAXED(op, asm_op)				\
+static inline long							\
+atomic64_fetch_##op##_relaxed(long a, atomic64_t *v)			\
+{									\
+	long res, t;							\
+									\
+	__asm__ __volatile__(						\
+"1:	ldarx	%0,0,%4		# atomic64_fetch_" #op "_relaxed\n"	\
+	#asm_op " %1,%3,%0\n"						\
+"	stdcx.	%1,0,%4\n"						\
+"	bne-	1b\n"							\
+	: "=&r" (res), "=&r" (t), "+m" (v->counter)			\
+	: "r" (a), "r" (&v->counter)					\
+	: "cc");							\
+									\
+	return t;							\

Looks like I missed this one in v1, it should be
	
	return res;

because the primitives will return the values before modified by the
operations.

Regards,
Boqun

+}
+

Attachments

signature.asc [application/pgp-signature] 473 bytes

`h`	back out one level
`j`	next message in thread
`k`	previous message in thread
`l`	drill in
`Esc`	close help / fold thread tree
`?`	toggle this help