Thread (13 messages) 13 messages, 3 authors, 2015-01-13

Re: [PATCH v2 1/5] perf tools: [uclibc] fix statfs.f_type data type mismatch build error

From: Arnaldo Carvalho de Melo <hidden>
Date: 2015-01-13 01:48:09
Also in: linux-perf-users, lkml

Em Mon, Jan 12, 2015 at 12:05:22PM +0100, Jiri Olsa escreveu:
On Sat, Jan 10, 2015 at 04:40:50PM +0530, Vineet Gupta wrote:
quoted
From: Alexey Brodkin <abrodkin@synopsys.com>

ARC Linux uses the no legacy syscalls abi and corresponding uClibc headers
statfs defines f_type to be U32 which causes perf build breakage

http://git.uclibc.org/uClibc/tree/libc/sysdeps/linux/common-generic/bits/statfs.h

----------->8---------------
  CC       fs/fs.o
fs/fs.c: In function 'fs__valid_mount':
fs/fs.c:82:24: error: comparison between signed and unsigned integer
expressions [-Werror=sign-compare]
  else if (st_fs.f_type != magic)
                        ^
cc1: all warnings being treated as errors
----------->8---------------

Cc: Borislav Petkov <redacted>
Cc: Jiri Olsa <jolsa@kernel.org>
Cc: Cody P Schafer <redacted>
Cc: Arnaldo Carvalho de Melo <redacted>
Cc: linux-perf-users@vger.kernel.org
Cc: linux-kernel@vger.kernel.org
Signed-off-by: Alexey Brodkin <abrodkin@synopsys.com>
Acked-by: Jiri Olsa <jolsa@kernel.org>
Thanks, applied, but please do not start lines in the changelog comment
with ---, that breaks some patch applying scripts. I fixed it up this
time.

- Arnaldo
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help