Thread (84 messages) 84 messages, 14 authors, 2015-01-27

Re: [PATCH v2 03/40] arm64/uaccess: fix sparse errors

From: "Michael S. Tsirkin" <mst@redhat.com>
Date: 2015-01-06 21:49:00
Also in: linux-arm-kernel, lkml

On Tue, Jan 06, 2015 at 07:14:32PM +0000, Will Deacon wrote:
Hi Michael,

On Tue, Jan 06, 2015 at 03:43:40PM +0000, Michael S. Tsirkin wrote:
quoted
virtio wants to read bitwise types from userspace using get_user.  At the
moment this triggers sparse errors, since the value is passed through an
integer.

Fix that up using __force.

Signed-off-by: Michael S. Tsirkin <mst@redhat.com>

Acked-by: Will Deacon <redacted>
---
Did you want us to take this via the arm64 tree, or are you planning to
merge it via another route?

Will
Up to you really: if you don't pick it up, Arnd said he'll merge
through his tree.
quoted
 arch/arm64/include/asm/uaccess.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/arm64/include/asm/uaccess.h b/arch/arm64/include/asm/uaccess.h
index 3bf8f4e..9a2069b 100644
--- a/arch/arm64/include/asm/uaccess.h
+++ b/arch/arm64/include/asm/uaccess.h
@@ -147,7 +147,7 @@ do {									\
 	default:							\
 		BUILD_BUG();						\
 	}								\
-	(x) = (__typeof__(*(ptr)))__gu_val;				\
+	(x) = (__force __typeof__(*(ptr)))__gu_val;			\
 } while (0)
 
 #define __get_user(x, ptr)						\
-- 
MST
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help