Thread (22 messages) 22 messages, 6 authors, 2014-09-30
STALE4319d
Revisions (2)
  1. v4 current
  2. v5 [diff vs current]

[PATCH v4 2/8] serial: sunzilog: Remove unnecessary volatile keyword

From: Thierry Reding <hidden>
Date: 2014-08-13 10:29:10
Also in: linux-arm-kernel, linux-s390, linux-serial, lkml, sparclinux
Subsystem: sparc serial drivers, the rest, tty layer and serial drivers · Maintainers: "David S. Miller", Linus Torvalds, Greg Kroah-Hartman, Jiri Slaby

From: Thierry Reding <redacted>

The field annotated with volatile are all accessed through I/O accessors
so they don't need to be explicitly marked. The accessors will take care
of it.

Signed-off-by: Thierry Reding <redacted>
---
Changes in v4:
- new patch

 drivers/tty/serial/sunzilog.h | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/tty/serial/sunzilog.h b/drivers/tty/serial/sunzilog.h
index 5dec7b47cc38..de2850c1ab57 100644
--- a/drivers/tty/serial/sunzilog.h
+++ b/drivers/tty/serial/sunzilog.h
@@ -2,10 +2,10 @@
 #define _SUNZILOG_H
 
 struct zilog_channel {
-	volatile unsigned char control;
-	volatile unsigned char __pad1;
-	volatile unsigned char data;
-	volatile unsigned char __pad2;
+	unsigned char control;
+	unsigned char __pad1;
+	unsigned char data;
+	unsigned char __pad2;
 };
 
 struct zilog_layout {
-- 
2.0.4
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help