On 8/28/2013 1:54 PM, Christoph Lameter wrote:

On Wed, 28 Aug 2013, Chris Metcalf wrote:

quoted

In addition, I applied the following commit to clean up the remaining
uses that are currently only being carried in the linux-tile tree.

You are going to merge these changes right? I can drop the tile patch from
my series?

Yes, I am, so please feel free to drop it.

One small issue below:

quoted

diff --git a/arch/tile/kernel/time.c b/arch/tile/kernel/time.c
index a7a41a1..30c2c34 100644
--- a/arch/tile/kernel/time.c
+++ b/arch/tile/kernel/time.c

@@ -286,7 +286,7 @@ static int _set_clock_rate_barrier;
 static int _set_clock_rate(void *arg)
 {
        struct _set_clock_rate_args *args = arg;
-       struct clock_event_device *evt = &__get_cpu_var(tile_timer);
+       struct clock_event_device *evt = get_cpu_ptr(&tile_timer);

					^^^^ this_cpu_ptr

Thanks, good catch.  Annoying to have preemption disabled forever otherwise :-)

-- 
Chris Metcalf, Tilera Corp.
http://www.tilera.com