Thread (67 messages) 67 messages, 11 authors, 2013-06-25

Re: [PATCH 25/45] staging/octeon: Use get/put_online_cpus_atomic() to prevent CPU offline

From: Srivatsa S. Bhat <hidden>
Date: 2013-06-24 17:28:49
Also in: linux-pm, linuxppc-dev, lkml, netdev

On 06/24/2013 12:47 AM, Joe Perches wrote:
On Mon, 2013-06-24 at 00:25 +0530, Srivatsa S. Bhat wrote:
quoted
On 06/23/2013 11:47 PM, Greg Kroah-Hartman wrote:
quoted
On Sun, Jun 23, 2013 at 07:13:33PM +0530, Srivatsa S. Bhat wrote:
[]
quoted
quoted
quoted
diff --git a/drivers/staging/octeon/ethernet-rx.c b/drivers/staging/octeon/ethernet-rx.c
[]
quoted
Honestly, I don't know. Let's CC the author of that code (David Daney).
I wonder why get_maintainer.pl didn't generate his name for this file,
even though the entire file is almost made up of his commits alone!
Because by default, get_maintainer looks for a matching
file entry in MAINTAINERS.  Failing that, it looks at
one year of git history.  In this case, no work has been
done on the file for quite awhile.

--git-blame can be added to the get_maintainer.pl command
line to look for % of authorship by line and commit count.

Adding --git-blame can take a long time to run, that's why
it's not on by default.  Also, very old history can give
invalid email addresses as people move around and email
addresses decay.

If you always want to find original authors, you could
use a .get_maintainer.conf file with --git-blame in it.

$ time ./scripts/get_maintainer.pl --git-blame -f drivers/staging/octeon/ethernet-tx.c
Greg Kroah-Hartman [off-list ref] (supporter:STAGING SUBSYSTEM,commits:4/16=25%)
David Daney [off-list ref] (authored lines:711/725=98%,commits:13/16=81%)
Ralf Baechle [off-list ref] (commits:11/16=69%)
Eric Dumazet [off-list ref] (commits:2/16=12%)
Andrew Morton [off-list ref] (commits:1/16=6%)
devel@driverdev.osuosl.org (open list:STAGING SUBSYSTEM)
linux-kernel@vger.kernel.org (open list)

real	0m16.853s
user	0m16.088s
sys	0m0.444s
Oh, ok.. Thanks for the explanation and the tip!

Regards,
Srivatsa S. Bhat
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help