Thread (117 messages) 117 messages, 14 authors, 2013-02-19

Re: [PATCH v5 14/45] rcu, CPU hotplug: Fix comment referring to stop_machine()

From: Srivatsa S. Bhat <hidden>
Date: 2013-02-10 19:45:17
Also in: linux-arm-kernel, linux-pm, linuxppc-dev, lkml, netdev

On 02/09/2013 05:44 AM, Paul E. McKenney wrote:
On Tue, Jan 22, 2013 at 01:06:34PM +0530, Srivatsa S. Bhat wrote:
quoted
Don't refer to stop_machine() in the CPU hotplug path, since we are going
to get rid of it. Also, move the comment referring to callback adoption
to the CPU_DEAD case, because that's where it happens now.

Signed-off-by: Srivatsa S. Bhat <redacted>
Ouch!  That comment is indeed obsolete and must die.

I queued this to -rcu with your Signed-off-by.  However, I omitted
the added comment, as it is imcomplete -- it is easy to look at
rcu_cleanup_dead_cpu() to see what it does.
Cool! I'll drop it from my patch series then. Thank you!

Regards,
Srivatsa S. Bhat
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help