Re: [PATCH, RESEND] asm-generic, mm: pgtable: consolidate zero page helpers

On Tue, Dec 11, 2012 at 07:07:14PM -0800, David Rientjes wrote:

On Fri, 7 Dec 2012, Kirill A. Shutemov wrote:

quoted

From: "Kirill A. Shutemov" <redacted>

We have two different implementation of is_zero_pfn() and
my_zero_pfn() helpers: for architectures with and without zero page
coloring.

Let's consolidate them in <asm-generic/pgtable.h>.

What's the benefit from doing this other than generalizing some per-arch 
code?  It simply adds on more layer of redirection to try to find the 
implementation that matters for the architecture you're hacking on.

The idea of asm-generic is consolidation arch code which can be re-used
for different arches. It also makes support of new arches easier.

Do you think have copy of the same code here and there is any better?

-- 
 Kirill A. Shutemov