Thread (103 messages) 103 messages, 10 authors, 2013-03-11

Re: [RFC PATCH v1 25/31] ARC: [plat-arcfpga] Hooking up platform to ARC UART

From: Arnd Bergmann <arnd@arndb.de>
Date: 2012-11-07 14:16:12
Also in: lkml

On Wednesday 07 November 2012, Vineet Gupta wrote:
+static struct platform_device arc_uart##n##_dev = {    \
+       .name = "arc-uart",                             \
+       .id = n,                                        \
+       .num_resources = ARRAY_SIZE(arc_uart##n##_res), \
+       .resource = arc_uart##n##_res,                  \
+       .dev = {                                        \
+               .platform_data = &arc_uart_info,        \
+       },                                              \
+}
+
+ARC_UART_DEV(0);
+#if CONFIG_SERIAL_ARC_NR_PORTS > 1
+ARC_UART_DEV(1);
+#endif
+
+static struct platform_device *fpga_early_devs[] __initdata = {
+#if defined(CONFIG_SERIAL_ARC_CONSOLE)
+       &arc_uart0_dev,
+#endif
+};
statically defining platform devices like this is considered very
bad style, especially since it prevents you from doing proper
boot-time configuration. Please get the available devices from
the boot loader. Normally this is done using a flattened device
tree blob that gets passed, unless you can probe the hardware
directly.

	Arnd
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help