Thread (8 messages) 8 messages, 5 authors, 2012-10-29

Re: [PATCH] asm-generic/io.h: remove asm/cacheflush.h include

From: Arnd Bergmann <arnd@arndb.de>
Date: 2012-10-25 14:08:09
Also in: lkml

On Thursday 25 October 2012, Jonas Bonn wrote:
On Tue, 2012-10-23 at 10:21 +0100, James Hogan wrote:
quoted
Including <asm/cacheflush.h> from <asm-generic/io.h> prevents
cacheflush.h being able to use I/O functions like readl and writel due
to circular include dependencies. It doesn't appear as if anything from
cacheflush.h is actually used by the generic io.h, so remove the
include.

I've compile tested a defconfig compilation of blackfin, openrisc (which
needed <asm/pgtable.h> including from it's <asm/io.h> to get the PAGE_*
definitions), and xtensa.

Other architectures which use asm-generic/io.h are score and unicore32,
and looking at their io.h I don't see any obvious problems.
Acked-by: Jonas Bonn <jonas@southpole.se> for OpenRISC

Who's tree should this go via.  I can take it via the openrisc tree, but
it would be good to get some Ack's that this isn't going to break things
for the other arch's (in particular score and unicore32, since they are
untested).
I've put it into the asm-generic tree, now that I have set it up again
for the 3.7 merge window.

	Arnd
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help