Re: [RESEND PATCH 4/4] net: smc91x: use io{read,write}*_rep accessors instead of string functions
From: Will Deacon <hidden>
Date: 2012-10-19 09:27:25
Also in:
lkml
From: Will Deacon <hidden>
Date: 2012-10-19 09:27:25
Also in:
lkml
On Fri, Oct 19, 2012 at 09:25:48AM +0100, James Hogan wrote:
On 17/10/12 16:45, Will Deacon wrote:quoted
The {read,write}s{b,w,l} operations are not defined by all architectures and are being removed from the asm-generic/io.h interface. This patch replaces the usage of these string functions in the default SMC accessors with io{read,write}{8,16,32}_rep calls instead, which are defined for all architectures.Hi, Should this patch (and the mmc one) precede patch 1?
Yup, I can reorder that easily enough.
Also there appear to be some other places that it's used (e.g. smsc911x.c and smc911x.h). I guess these should be fixed up first too?
I could have a look if you like, but I'm wary of changing the I/O accessors in anything but a mechanical fashion given that I can't test any of my changes. Will