On Tue, Jul 3, 2012 at 9:34 PM, Russell King - ARM Linux
[off-list ref] wrote:

On Tue, Jul 03, 2012 at 01:19:40PM +0000, Arnd Bergmann wrote:

quoted

On Tuesday 03 July 2012, Alessandro Rubini wrote:

quoted

   drivers/dma/amba-pl08x.c: needs <asm/hardware/pl080.h>
     proposed fix: move pl080.h to include/linux

Note that there is already an include/linux/amba/pl08x.h.
I would just move the few parts of pl080.h that are actually
needed with global visibility there, and move the rest
to drivers/dma/.

NAK.  It's the entire register definitions for the PL08x, which we really
should not be exporting to common code.

The major reason why that file is there is that there is *another*
PL080 driver in arch/arm/mach-s3c64xx/dma.c which I repeatedly
asked the Samsung people to replace with the
drivers/dma/amba-pl08x.c driver. :-(

When I worked on the PL08x driver in drivers/dma I reused
this header to avoid code duplication.

Now that thing is stranding in the way. Alim, Kukjin, what's happening?

I feel tempted to update Alim's patch myself and push it on you
soon...

Please wait until _after_ my DMA engine stuff (which is now in linux-next)
makes its way upstream before touching any of this stuff, otherwise there's
going to be conflicts.

That stuff is in now, looking real good. Good work on this!

As part of my patch series, this gets rid of a number of uses of it in
arch/arm, but there's still the .cctl_memcpy initializer which does. I've
not yet checked whether all implementations use the same value (they
probably do), and if so then it should be eliminated from platform code
and moved into the driver.

Sounds like a plan. If we just get rid of the duplicate implementation
we're going somewhere.

Yours,
Linus Walleij