Re: [PATCH 12/24] PCI, ia64: Register busn_res for root buses
From: Bjorn Helgaas <bhelgaas@google.com>
Date: 2012-02-29 00:23:12
Also in:
linux-pci, lkml
On Tue, Feb 28, 2012 at 5:12 PM, Yinghai Lu [off-list ref] wrote:
On Tue, Feb 28, 2012 at 4:01 PM, Bjorn Helgaas [off-list ref] wrote:quoted
On Tue, Feb 28, 2012 at 3:07 PM, Yinghai Lu [off-list ref] wrote:quoted
Signed-off-by: Yinghai Lu <yinghai@kernel.org> Cc: Tony Luck <tony.luck@intel.com> Cc: Fenghua Yu <redacted> Cc: linux-ia64@vger.kernel.org --- arch/ia64/include/asm/pci.h | 1 + arch/ia64/pci/pci.c | 5 +++++ 2 files changed, 6 insertions(+), 0 deletions(-)diff --git a/arch/ia64/include/asm/pci.h b/arch/ia64/include/asm/pci.h index b22e5f5..6e54220 100644 --- a/arch/ia64/include/asm/pci.h +++ b/arch/ia64/include/asm/pci.h@@ -94,6 +94,7 @@ struct pci_controller {unsigned int windows; struct pci_window *window; + struct resource busn;Why do you add a new struct resource here? Can't you just use the one passed in from acpi_pci_root_add()?not quite sure about the life cycle for that object.
The struct acpi_pci_root is allocated in acpi_pci_root_add() and freed in acpi_pci_root_remove(), so it should be safe for PCI to use. Same thing applies for x86, of course. Bjorn