Thread (33 messages) 33 messages, 2 authors, 2012-02-10

Re: [PATCH v2 00/18] add PCI bus-to-resource offset support in core

From: Yinghai Lu <yinghai@kernel.org>
Date: 2012-02-10 20:25:25
Also in: linux-pci

On Fri, Feb 10, 2012 at 9:24 AM, Bjorn Helgaas [off-list ref] wrote:
On Fri, Feb 10, 2012 at 9:20 AM, Yinghai Lu [off-list ref] wrote:

That's exactly what I said above, isn't it?  (In the paragraph
starting "Let me try again.")
no, not create one. make them looks like one struct with some common fields.
As I said, the reason I don't like that approach is that I don't want
a dozen copies of first_busno, last_busno, domain, node, io_offset,
mem_offset, etc.  That information is not architecture-specific, so we
shouldn't keep it in an architecture-specific struct.
but you want to add hostbridge struct list and that just produce
duplicated info.
and search hostbridge for dev looks not good.
Now you try to: for every device or resource find root bus and then
check hostbridge list to get hostbridge and get offset.

use sysdata pointer to get sys data like hostbridge info quickly

i drafted one patch, and it seems not ugly with macro. please check it.

Thanks

Yinghai

Attachments

Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help