Re: [PATCH 4/8] ARM: dma-mapping: implement dma sg methods on top of generic dma ops
From: KyongHo Cho <hidden>
Date: 2011-06-20 14:37:55
Also in:
linux-arm-kernel, linux-mm
From: KyongHo Cho <hidden>
Date: 2011-06-20 14:37:55
Also in:
linux-arm-kernel, linux-mm
Hi. On Mon, Jun 20, 2011 at 4:50 PM, Marek Szyprowski [off-list ref] wrote:
-extern int arm_dma_map_sg(struct device *, struct scatterlist *, int, +extern int generic_dma_map_sg(struct device *, struct scatterlist *, int, enum dma_data_direction, struct dma_attrs *attrs); -extern void arm_dma_unmap_sg(struct device *, struct scatterlist *, int, +extern void generic_dma_unmap_sg(struct device *, struct scatterlist *, int, enum dma_data_direction, struct dma_attrs *attrs); -extern void arm_dma_sync_sg_for_cpu(struct device *, struct scatterlist *, int, +extern void generic_dma_sync_sg_for_cpu(struct device *, struct scatterlist *, int, enum dma_data_direction); -extern void arm_dma_sync_sg_for_device(struct device *, struct scatterlist *, int, +extern void generic_dma_sync_sg_for_device(struct device *, struct scatterlist *, int, enum dma_data_direction);
I don't understand why you changed arm_dma_*() with generic_dma_*() even though they're functionality is not changed and they are still specific to ARM. They look like that they are generic in the kernel code. Regards, Cho KyongHo.