Thread (11 messages) 11 messages, 4 authors, 2011-06-20

Re: [RFC] get_write_access()/deny_write_access() without inode->i_lock

From: David Howells <dhowells@redhat.com>
Date: 2011-06-20 13:21:11
Also in: linux-fsdevel, lkml

David Howells [off-list ref] wrote:
quoted
+	for (v = atomic_read(&inode->i_writecount); v >= 0; v = v1) {
+		v1 = atomic_cmpxchg(&inode->i_writecount, v, v + 1);
+		if (likely(v1 == v))
+			return 0;
+	}
You don't need to reissue the atomic_read().  atomic_cmpxchg() returns the
current value of the memory location.  Just set v to v1 before going round the
loop again.
Ah...  Never mind - you did that anyway.

David
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help