Re: [PATCH 14/19] OpenRISC: Module support
From: Rusty Russell <hidden>
Date: 2011-06-25 05:01:40
Also in:
lkml
From: Rusty Russell <hidden>
Date: 2011-06-25 05:01:40
Also in:
lkml
On Fri, 24 Jun 2011 12:05:31 +0200, Arnd Bergmann [off-list ref] wrote:
On Friday 24 June 2011, Jonas Bonn wrote:quoted
I noticed that kernel/module.c already has this: unsigned int __weak arch_mod_section_prepend(struct module *mod, unsigned int section) Is using a __weak attribute on the default (generic) implementations a better approach?I normally don't like using __weak, because it more easily confuses readers about which version is actually used.
I share your reluctance with __weak, but as fewer people want to touch multiple archs it is becoming the norm. Would happily accept patches... Thanks, Rusty.