Thread (38 messages) 38 messages, 10 authors, 2012-05-21

Re: [RFC][PATCH 4/6] arm, mm: Convert arm to generic tlb

From: Catalin Marinas <catalin.marinas@arm.com>
Date: 2011-03-09 15:16:10
Also in: linux-mm, lkml

Hi Peter,

On 2 March 2011 17:59, Peter Zijlstra [off-list ref] wrote:
quoted hunk ↗ jump to hunk
--- linux-2.6.orig/arch/arm/include/asm/tlb.h
+++ linux-2.6/arch/arm/include/asm/tlb.h
[...]
+__pte_free_tlb(struct mmu_gather *tlb, pgtable_t pte, unsigned long addr)
 {
       pgtable_page_dtor(pte);
-       tlb_add_flush(tlb, addr);
       tlb_remove_page(tlb, pte);
 }
I think we still need a tlb_track_range() call here. On the path to
pte_free_tlb() (for example shift_arg_pages ... free_pte_range) there
doesn't seem to be any code setting the tlb->start/end range. Did I
miss anything?

Thanks.

-- 
Catalin
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help