On Friday 18 February 2011 11:28:45 Guan Xuetao wrote:

  * Register numbers.
  */
-#define I8042_COMMAND_REG      ((unsigned long)&PS2_COMMAND)
-#define I8042_STATUS_REG       ((unsigned long)&PS2_STATUS)
-#define I8042_DATA_REG         ((unsigned long)&PS2_DATA)
+#define I8042_COMMAND_REG      ((volatile void __iomem *)&PS2_COMMAND)
+#define I8042_STATUS_REG       ((volatile void __iomem *)&PS2_STATUS)
+#define I8042_DATA_REG         ((volatile void __iomem *)&PS2_DATA)
+
+#define I8042_REGION_START     (resource_size_t)(&PS2_DATA)
+#define I8042_REGION_SIZE      (resource_size_t)(16)

It would be better to remove the cast and make the PS2_COMMAND
etc macros have the correct type. Aside from this, the change
looks good.

	Arnd