Thread (6 messages) 6 messages, 2 authors, 2011-02-27

Re: [PATCHv2 06/11] unicore32 core architecture: mm related: generic codes

From: Arnd Bergmann <arnd@arndb.de>
Date: 2011-02-17 17:28:21
Also in: lkml

On Sunday 13 February 2011, Guan Xuetao wrote:
This patch includes generic codes for memory management.

Signed-off-by: Guan Xuetao <redacted>
Reviewed-by: Arnd Bergmann <arnd@arndb.de>
quoted hunk ↗ jump to hunk
+#ifdef __io
+void __iomem *ioport_map(unsigned long port, unsigned int nr)
+{
+       /* we map PC lagcy 64K IO port to PCI IO space 0x80030000 */
+       return (void __iomem *) (unsigned long)
+                       io_p2v((port & 0xffff) + PKUNITY_PCILIO_BASE);
+}
Interestingly, this function looks completely correct, but I don't see
the definition for __io, so I suspect that the function is not actually
getting used.

Best make this unconditional. The code is obviously derived from the
ARM version, which uses a macro called __io, but you don't need this
macro because you only support one SoC platform.

	Arnd
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help