Thread (11 messages) 11 messages, 4 authors, 2011-01-10

Re: [PATCHv1 01/12] unicore32 core architecture: build infrastructure

From: Sam Ravnborg <hidden>
Date: 2011-01-08 14:07:43
Also in: lkml

quoted
Overall, I can see that there has been a lot of good progress in the code since
the original versions that I looked at, very nice!
quoted
diff --git a/arch/unicore32/.gitignore b/arch/unicore32/.gitignore
new file mode 100644
index 0000000..f0fc866
--- /dev/null
+++ b/arch/unicore32/.gitignore
@@ -0,0 +1,70 @@
+#
+# Generated include files
+#
+include/asm/atomic.h
+include/asm/auxvec.h
+include/asm/bitsperlong.h
+include/asm/bug.h
+include/asm/bugs.h
+include/asm/cputime.h
+include/asm/current.h
+include/asm/device.h
+include/asm/emergency-restart.h
+include/asm/errno.h
+include/asm/fb.h
+include/asm/fcntl.h
+include/asm/hardirq.h
...
Maybe it would be better to put these files into a separate directory, like
arch/unicore32/include/generated/asm, to make it easier to separate them
from the other files and avoid listing them all in .gitignore besides the
other places.
That's great, and I make the following changes:
...

I have made a second attempt to provice generic support
for asm-generic headers as you likely have seen.

IMO you shall keep your own solution until we get
generic support.
In other words - you shall avoid being dependent on this.

	Sam
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help