On Sun, 10 Aug 2008 14:13:32 +0200 (CEST)
Geert Uytterhoeven [off-list ref] wrote:

On Wed, 23 Jul 2008, akpm@linux-foundation.org wrote:

quoted

Remove the size parameter from the new epoll_create syscall and renames the
syscall itself.  The updated test program follows.

~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
#include <fcntl.h>
#include <stdio.h>
#include <time.h>
#include <unistd.h>
#include <sys/syscall.h>

#ifndef __NR_epoll_create2

			   ^
The test program still uses __NR_epoll_create2 instead of
__NR_epoll_create1 everywhere.

Which test program is that?

quoted

diff -puN fs/eventpoll.c~flag-parameters-add-on-remove-epoll_create-size-param fs/eventpoll.c

--- a/fs/eventpoll.c~flag-parameters-add-on-remove-epoll_create-size-param
+++ a/fs/eventpoll.c

@@ -1046,7 +1046,7 @@ retry:
  * RB tree. With the current implementation, the "size" parameter is ignored

                                                ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

quoted

  * (besides sanity checks).

      ^^^^^^^^^^^^^^^^^^^^^^^

quoted

  */
-asmlinkage long sys_epoll_create2(int size, int flags)
+asmlinkage long sys_epoll_create1(int flags)

The function comment was not updated for the removal of the `size'
parameter. Can you please fix that?

I did this:

From: Andrew Morton <akpm@linux-foundation.org>

The `size' argument was removed.

Reported-by:  Geert Uytterhoeven <geert@linux-m68k.org>
Cc: Ulrich Drepper <redacted>
Cc: Davide Libenzi <redacted>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
---

 fs/eventpoll.c |    5 +----
 1 file changed, 1 insertion(+), 4 deletions(-)

diff -puN fs/eventpoll.c~fs-eventpollc-fix-sys_epoll_create1-comment fs/eventpoll.c

--- a/fs/eventpoll.c~fs-eventpollc-fix-sys_epoll_create1-comment
+++ a/fs/eventpoll.c

@@ -1041,10 +1041,7 @@ retry:
 }
 
 /*
- * It opens an eventpoll file descriptor. The "size" parameter is there
- * for historical reasons, when epoll was using an hash instead of an
- * RB tree. With the current implementation, the "size" parameter is ignored
- * (besides sanity checks).
+ * Open an eventpoll file descriptor.
  */
 asmlinkage long sys_epoll_create1(int flags)
 {

_