Re: [PATCH 02/20] lib: generic show_mem()
From: Heiko Carstens <hidden>
Date: 2008-07-05 08:35:31
Also in:
lkml
On Fri, Jul 04, 2008 at 06:07:39PM +0200, Johannes Weiner wrote:
quoted hunk ↗ jump to hunk
This implements a platform-independent version of show_mem(). Signed-off-by: Johannes Weiner <redacted> --- lib/Makefile | 2 - lib/show_mem.c | 63 +++++++++++++++++++++++++++++++++++++++++++++++++++++++++ 2 files changed, 64 insertions(+), 1 deletion(-)--- a/lib/Makefile +++ b/lib/Makefile@@ -6,7 +6,7 @@ lib-y := ctype.o string.o vsprintf.o cmd rbtree.o radix-tree.o dump_stack.o \ idr.o int_sqrt.o extable.o prio_tree.o \ sha1.o irq_regs.o reciprocal_div.o argv_split.o \ - proportions.o prio_heap.o ratelimit.o + proportions.o prio_heap.o ratelimit.o show_mem.o ifdef CONFIG_FTRACE # Do not profile string.o, since it may be used in early boot or vdso --- /dev/null +++ b/lib/show_mem.c@@ -0,0 +1,63 @@ +/* + * Generic show_mem() implementation + * + * Copyright (C) 2008 Johannes Weiner <hannes@saeurebad.de> + * All code subject to the GPL version 2. + */ + +#include <linux/mm.h> +#include <linux/nmi.h> +#include <linux/quicklist.h> + +void show_mem(void) +{
Umh.. I think your 4th patch set was the way to go. This set is not bisectable anymore and those architectures which you didn't convert to the generic implementation won't build anymore. show_mem is present twice there... You might solve this by adding an __attribute__((weak)) but I'm sure people will complain again, because it produces dead code for all architectures which got converted.