Re: [patch 02/41] cpu alloc: The allocator
From: Pavel Machek <hidden>
Date: 2008-06-01 14:19:45
Also in:
lkml
Hi!
quoted hunk ↗ jump to hunk
Index: linux-2.6/mm/Kconfig ===================================================================--- linux-2.6.orig/mm/Kconfig 2008-05-29 19:41:21.000000000 -0700 +++ linux-2.6/mm/Kconfig 2008-05-29 20:13:39.000000000 -0700@@ -205,3 +205,9 @@ config NR_QUICK config VIRT_TO_BUS def_bool y depends on !ARCH_NO_VIRT_TO_BUS + +config CPU_ALLOC_SIZE + int "Size of cpu alloc area" + default "30000" + help + Sets the maximum amount of memory that can be allocated via cpu_alloc
Missing . at end of line, but more important: How do you expect user to answer this?! I mean, can they put 0 there and expect kernel to work? If not, you should disallow that config. And you shoudl really explain how much memory is needed... and perhaps mention that size is in bytes? -- (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html