Thread (2 messages) 2 messages, 2 authors, 2004-03-01

Re: remove irq_enter()/irq_exit() from hardirq.h

From: Martin Schwidefsky <hidden>
Date: 2004-03-01 12:20:24



quoted
but I'm wondering whether
leaving irq_enter()/irq_exit() in hardirq.h might invite someone to
use it outside of architecture-specific code (which is not the case at
the moment, as far as I can see).
I agree with you, it shouldn't be publicly visible.  The s390 guys will
need to do some work as their drivers reference these two routines (ie.
grep under drivers/s390/)
Well, drivers/s390/cio is not really a driver. The main interrupt function
for i/o interrupts do_IRQ lives in driver/s390/cio/cio.c and not in
arch/s390/kernel/irq.c where you might expect to find it. The irq_enter/
irq_exit pair we just added in the sclp driver can be replaced with
a local_bh_enable/local_bh_disable pair. So we are pretty clean.

blue skies,
   Martin

Linux/390 Design & Development, IBM Deutschland Entwicklung GmbH
Schönaicherstr. 220, D-71032 Böblingen, Telefon: 49 - (0)7031 - 16-2247
E-Mail: schwidefsky@de.ibm.com
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help