Re: [PATCH v3 1/2] ptrace: reject out of range error values in PTRACE_SET_SYSCALL_INFO

From
Oleg Nesterov <oleg@redhat.com>
Date
2026-11-16 12:58:38
Also in
linux-kselftest, lkml
Reply to
Renzo Davoli, 2026-11-15
On 11/15, Renzo Davoli wrote:
quoted hunk ↗ jump to hunk
With is_error set, PTRACE_SET_SYSCALL_INFO passes info.exit.rval to
syscall_set_return_value() as an "int" error without checking it: a
positive value, or on 64-bit one outside the "int" range, turns the
error into a success or is truncated.

Reject with -ERANGE any error value outside [-MAX_ERRNO, -1].

Fixes: 26bb32768fe6 ("ptrace: introduce PTRACE_SET_SYSCALL_INFO request")
Reviewed-by: Dmitry V. Levin <redacted>
Reviewed-by: Bradley Morgan <redacted>
Signed-off-by: Renzo Davoli <redacted>
---
 kernel/ptrace.c | 4 ++++
 1 file changed, 4 insertions(+)
diff --git a/kernel/ptrace.c b/kernel/ptrace.c
index 3f2fe68ccb14..1ffacfcef8d4 100644
--- a/kernel/ptrace.c
+++ b/kernel/ptrace.c
@@ -1111,6 +1111,10 @@ ptrace_set_syscall_info_exit(struct task_struct *child, struct pt_regs *regs,
 	if (rval != info->exit.rval)
 		return -ERANGE;

+	/* An error must be a negative errno value. */
+	if (info->exit.is_error && (rval < -MAX_ERRNO || rval >= 0))
+		return -ERANGE;
+
	if (info->exit.is_error && !IS_ERR_VALUE(rval))

?

Oleg.
Thread (5 messages) 5 messages, 3 authors, last reply 38m ago
Keyboard shortcuts
hback out one level
jnext message in thread / next series-diff position
kprevious message in thread / previous series-diff position
ldrill in
Escclose help / fold thread tree
?toggle this help