Re: [PATCH RFC 20/20] attestation: Add the TDX family implementation

From
Jason Gunthorpe <jgg@ziepe.ca>
Date
2026-11-09 17:12:39
Also in
kvm, linux-coco, linux-doc, lkml
Reply to
Peter Fang, 2026-11-06
On Fri, Nov 06, 2026 at 01:47:52PM -0800, Peter Fang wrote:
For TDX, the direction so far has been to keep the guest as simple as
possible in the attestation process. So the "quote type" knowledge is
pushed into the TDX module and the remote verifier. The host kernel is
mostly tasked with transporting the quote blob from the TDX module back
to the guest. In other words, TDX doesn't have any quote type knowledge
outside of the module itself. And as far as I know, parsing these blobs
is sort of a pain.

The TDX DICE blobs are actually self-describing, meaning the verifier
can follow a schema, parse the blob straight away, and know what's
inside, including how to verify the signature. They're also
distinguishable from the legacy quotes. A launched guest is guaranteed
to have a stable format for its quotes. So this makes me wonder how the
labeling should be done. Do you think it makes sense to just have a
"primary raw TDX quote" label and let the TDX quote blob describe
itself? Also, I think currently there are no plans to add
secondary/supplementary blobs alongside the quote itself.
I would be very happy if Intel came with some plan, documented in the
ABI comments around their labels down the road.

What I would like is that given a specific label any userspace can do
a verification and full dump of that data, including signature
validation, without need of any further external information.

Ie it is entirely self describing under that label.

So if someone has to say externally 'oh this was a legacy VM' to make
parsing work then that needs to go in the label.

Think of it this way, you should be able to run a command, lets imagine:

$ attestctl dump report0
   intel TDX A:
     - Field 1
     - Field 2
   Signature VALID
   Certificate chain
      A
      B
      C

It must not be something like:

$ attestctl dump report0 --kind tdx_legacy
$ attestctl dump report0 --kind tdx_dice

Does it make sense?

Whatever labeling you choose has to follow these goals, and there is
some trade off between making thing self describing forever into the
future and exposing protocol details into the guest kernel driver.

The future scares me so I would always design to include a description
of the blob from TDX module to the guest driver :)

Jason
Thread (212 messages) 212 messages, 15 authors, last reply 6d ago
Keyboard shortcuts
hback out one level
jnext message in thread / next series-diff position
kprevious message in thread / previous series-diff position
ldrill in
Escclose help / fold thread tree
?toggle this help