Re: [PATCH bpf-next v13 6/8] bpf: Add syscall common attributes support for map_create

On 12/5/26 01:07, Alexei Starovoitov wrote:

On Mon May 11, 2026 at 9:19 AM PDT, bot+bpf-ci wrote:

[...]

quoted

Looking at bpf_check() in kernel/bpf/verifier.c (around the verifier log
finalization), it uses similar logic with 'err = ret;' reassignment. However,
that doesn't appear to have the preserve-original-error comment that would
clarify the intended behavior for this scenario.

I guess sinle line comment wouldn't hurt.

Will add a single line comment.

quoted

quoted

+	}
+
+free:

Does anything use this free: label? The only exit path before it is the early
return for IS_ERR(log), which correctly returns directly since log is an error
pointer and doesn't need cleanup. There doesn't seem to be any 'goto free;'
statement in the function.

With -Wunused-label enabled by default in the kernel build (part of -Wall),
this will generate a compiler warning. When building with -Werror (common in
CI configurations and allmodconfig builds), this would break the build.

good point. pls fix.

Will fix.

Thanks,
Leon