Re: [PATCH net-next] net: uapi: Provide an UAPI definition of 'struct sockaddr'
From: Thomas Weißschuh <hidden>
Date: 2026-01-06 10:33:06
Also in:
lkml, netdev
From: Thomas Weißschuh <hidden>
Date: 2026-01-06 10:33:06
Also in:
lkml, netdev
Hi Jakub, On Mon, Jan 05, 2026 at 09:57:13AM -0800, Jakub Kicinski wrote:
On Mon, 05 Jan 2026 09:25:55 +0100 Thomas Weißschuh wrote:quoted
Various UAPI headers reference 'struct sockaddr'. Currently the definition of this struct is pulled in from the libc header sys/socket.h. This is problematic as it introduces a dependency on a full userspace toolchain. Instead expose a custom but compatible definition of 'struct sockaddr' in the UAPI headers. It is guarded by the libc compatibility infrastructure to avoid potential conflicts. The compatibility symbol won't be supported by glibc right away, but right now __UAPI_DEF_IF_IFNAMSIZ is not supported either, so including the libc headers before the UAPI headers is broken anyways.I did not look too closely but this seems to break build of selftests in netdev and BPF CI (netdev on AWS Linux, not sure what base BPF uses)
Thanks for the report. I found the reported CI failures in BPF CI and will work on those. As for the failure in netdev CI however I am not so sure. Looking at net-next-2026-01-05--12-00, the only failures triggered by my change are also the ones from the bpf-ci. Are these the ones you meant, or am I missing some others? Thomas