Thread (92 messages) flat view 92 messages, 6 authors, 2025-11-24

Re: [PATCH v6 07/20] liveupdate: luo_session: Add ioctls for file preservation

From: Pasha Tatashin <pasha.tatashin@soleen.com>
Date: 2025-11-18 02:59:08
Also in: linux-doc, linux-fsdevel, linux-mm, lkml

quoted
 static int luo_session_release(struct inode *inodep, struct file *filep)
 {
      struct luo_session *session = filep->private_data;
      struct luo_session_header *sh;
+     int err = 0;

      /* If retrieved is set, it means this session is from incoming list */
-     if (session->retrieved)
+     if (session->retrieved) {
              sh = &luo_session_global.incoming;
-     else
+
+             err = luo_session_finish_one(session);
+             if (err) {
+                     pr_warn("Unable to finish session [%s] on release\n",
+                             session->name);
                        return err;

and then else can go away here and luo_session_remove() and
luo_session_free() can be moved outside if (session->retrieved).
Done.

Thanks,
Pasha
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help