Re: [PATCH 2/2] fs: return EOPNOTSUPP from file_setattr/file_getattr syscalls
From: Jan Kara <jack@suse.cz>
Date: 2025-10-08 13:30:15
Also in:
linux-fsdevel, linux-xfs, lkml
On Wed 08-10-25 14:44:18, Andrey Albershteyn wrote:
These syscalls call to vfs_fileattr_get/set functions which return ENOIOCTLCMD if filesystem doesn't support setting file attribute on an inode. For syscalls EOPNOTSUPP would be more appropriate return error. Signed-off-by: Andrey Albershteyn <aalbersh@kernel.org>
Looks good. Feel free to add: Reviewed-by: Jan Kara <jack@suse.cz> Honza
quoted hunk ↗ jump to hunk
--- fs/file_attr.c | 4 ++++ 1 file changed, 4 insertions(+)diff --git a/fs/file_attr.c b/fs/file_attr.c index 460b2dd21a85..5e3e2aba97b5 100644 --- a/fs/file_attr.c +++ b/fs/file_attr.c@@ -416,6 +416,8 @@ SYSCALL_DEFINE5(file_getattr, int, dfd, const char __user *, filename, } error = vfs_fileattr_get(filepath.dentry, &fa); + if (error == -ENOIOCTLCMD) + error = -EOPNOTSUPP; if (error) return error;@@ -483,6 +485,8 @@ SYSCALL_DEFINE5(file_setattr, int, dfd, const char __user *, filename, if (!error) { error = vfs_fileattr_set(mnt_idmap(filepath.mnt), filepath.dentry, &fa); + if (error == -ENOIOCTLCMD) + error = -EOPNOTSUPP; mnt_drop_write(filepath.mnt); }-- 2.51.0
-- Jan Kara [off-list ref] SUSE Labs, CR