On 2025-10-01, Askar Safin [off-list ref] wrote:

Aleksa Sarai [off-list ref]:

quoted

+mntfd2 = open_tree(mntfd1, "", OPEN_TREE_CLONE,
+                   &attr, sizeof(attr));

Your whole so-called "open_tree_attr example" doesn't contain any open_tree_attr
calls. :)

I think you meant open_tree_attr here.

Oops.

quoted

+\&
+/* Create a new copy with the id-mapping cleared */
+memset(&attr, 0, sizeof(attr));
+attr.attr_clr = MOUNT_ATTR_IDMAP;
+mntfd3 = open_tree(mntfd1, "", OPEN_TREE_CLONE,
+                   &attr, sizeof(attr));

And here.

Oops x2.

Otherwise your whole patchset looks good. Add to whole patchset:
Reviewed-by: Askar Safin <redacted>

-- 
Aleksa Sarai
Senior Software Engineer (Containers)
SUSE Linux GmbH
https://www.cyphar.com/